-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[FIX] Inventory: Fixing reordering rules navigation #11605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f1c8c9e to
edf767d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @benderliz
Thank you for addressing the task feedback so quickly!
Approving with a few comments below; please address what you agree with and can merge in when you're done 👍
Also, for this:
I will need to revise this whole doc with new screenshots for 18.0
Feel free to make the similar, targeted navigational revision in 18.0 as a new quick PR like this one (another 1-2 point), and then for that larger revision (or complete rewrite), do as a follow-up PR to that for another 3 or 5 points.
Although related, these are 3 separate tasks (2 address the community feedback, and 1 is your own initiative) so if we similarly execute them in this modular way it becomes a) easier for us to track changes and b) you get the full point value 🤙
..
@robodoo delegate=benderliz
| - :guilabel:`On Hand`: The number of units currently available in inventory. | ||
| - :guilabel:`Forecast`: The number of units expected to be available in inventory after all orders | ||
| are taken into account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you added more context to the UI here. I think for this particular operation, the On Hand and Forecast values are not editable for a New rule line (on my screen it's grayed out and the cursor goes right to the Route field, screenshot below)...
...which, makes sense since Route Min Quantity Max Quantity and To Order are the inputs directly tied to the RR, whereas the other two are more closely tied to making an inventory adjustment.
My suggestion is to remove these list items, or optionally add a see also admonition that points to any relevant docs on how to make an inventory adjustment.
...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst
Outdated
Show resolved
Hide resolved
...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst
Outdated
Show resolved
Hide resolved
|
@fw-bot ignore up to saas-17.4 |
Hi @StraubCreative! Thanks so much for the quick review, and I appreciate all the direction. That makes a lot of sense - after making revisions/merging this one, I will open a PR for the navigational change in 18.0, and then I'll open a new task for making longer fixes in a separate PR. Cheers! |
edf767d to
c7f77ef
Compare
|
@robodoo r+ |
closes #11605 Signed-off-by: Liz Bender (beli) <beli@odoo.com>


Doc task # 4411255